Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: device/serial/serial.mojom

Issue 562563002: Make some fields non-nullable in serial.mojom and data_stream.mojom. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/data_stream.mojom ('k') | extensions/renderer/api/serial/serial_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/serial.mojom
diff --git a/device/serial/serial.mojom b/device/serial/serial.mojom
index 92e6a9e2c31a86015820d9257d5728129843ff0f..89f0bcd49ed199bab66d135a4a72f8d4230f0921 100644
--- a/device/serial/serial.mojom
+++ b/device/serial/serial.mojom
@@ -7,7 +7,7 @@ import "data_stream.mojom"
module device.serial {
struct DeviceInfo {
- string? path;
+ string path;
uint16 vendor_id;
bool has_vendor_id = false;
uint16 product_id;
@@ -82,7 +82,7 @@ struct DeviceControlSignals {
};
interface SerialService {
- GetDevices() => (DeviceInfo?[]? devices);
+ GetDevices() => (DeviceInfo[] devices);
// Creates a |Connection| to |path| with options specified by |options|,
// returning it via |connection|. Sending and receiving data over this
@@ -90,17 +90,17 @@ interface SerialService {
// and |connection| will not be usable if |path| does not specify a valid
// serial device or there is an error connecting to or configuring the
// connection.
- Connect(string? path,
+ Connect(string path,
ConnectionOptions? options,
- Connection&? connection,
- DataSink&? sink,
- DataSource&? source);
+ Connection& connection,
+ DataSink& sink,
+ DataSource& source);
};
interface Connection {
GetInfo() => (ConnectionInfo? info);
- SetOptions(ConnectionOptions? options) => (bool success);
- SetControlSignals(HostControlSignals? signals) => (bool success);
+ SetOptions(ConnectionOptions options) => (bool success);
+ SetControlSignals(HostControlSignals signals) => (bool success);
GetControlSignals() => (DeviceControlSignals? signals);
Flush() => (bool success);
};
« no previous file with comments | « device/serial/data_stream.mojom ('k') | extensions/renderer/api/serial/serial_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698