Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: device/serial/data_source_sender.cc

Issue 562563002: Make some fields non-nullable in serial.mojom and data_stream.mojom. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/data_sink_receiver.cc ('k') | device/serial/data_stream.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/data_source_sender.cc
diff --git a/device/serial/data_source_sender.cc b/device/serial/data_source_sender.cc
index c240303973c4dee55b400205544088446e11d29e..e67a81ea17e189fbb6961bb75438e01d91c6fcfb 100644
--- a/device/serial/data_source_sender.cc
+++ b/device/serial/data_source_sender.cc
@@ -90,9 +90,8 @@ DataSourceSender::~DataSourceSender() {
void DataSourceSender::Init(mojo::ScopedDataPipeProducerHandle handle) {
// This should never occur. |handle_| is only valid and |pending_send_| is
- // only set after Init is called. Receiving an invalid |handle| from the
- // client is also unrecoverable.
- if (pending_send_ || handle_.is_valid() || !handle.is_valid() || shut_down_) {
+ // only set after Init is called.
+ if (pending_send_ || handle_.is_valid() || shut_down_) {
DispatchFatalError();
return;
}
« no previous file with comments | « device/serial/data_sink_receiver.cc ('k') | device/serial/data_stream.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698