extensions/renderer/resources/serial_service.js - Issue 562563002: Make some fields non-nullable in serial.mojom and data_stream.mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/serial_service.js

Issue 562563002: Make some fields non-nullable in serial.mojom and data_stream.mojom. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/resources/serial_service.js

diff --git a/extensions/renderer/resources/serial_service.js b/extensions/renderer/resources/serial_service.js

index 60b0afd6c0a0cca18c1d9808935ae821feecec61..0e0327d83c3207510d3f8d18042b614e2d33ef5d 100644

--- a/extensions/renderer/resources/serial_service.js

+++ b/extensions/renderer/resources/serial_service.js

@@ -30,7 +30,7 @@ define('serial_service', [

function getDevices() {

return service.getDevices().then(function(response) {

return $Array.map(response.devices, function(device) {

- var result = {path: device.path || ''};

+ var result = {path: device.path};

if (device.has_vendor_id)

result.vendorId = device.vendor_id;

if (device.has_product_id)

« no previous file with comments | « extensions/renderer/api/serial/serial_api_unittest.cc ('k') | no next file » | no next file with comments »