Move the last extensions/common unit tests to extensions_unittests

Move the last extensions/common unit tests to extensions_unittests

They don't need to run in Chrome's unit_tests suite any more.

* Move ExtensionL10UtilTest
* Move FileUtilTest
* Keep browser action and page action tests in Chrome, since those are
  Chrome-specific concepts

This CL depends on https://codereview.chromium.org/565423003/ for cleanup
of _manifest_features.json

BUG=397165
TEST=extensions_unittests, unit_tests

Committed: https://crrev.com/f765cb48310ab9d5dcaba7ec118115a32dd7c964
Cr-Commit-Position: refs/heads/master@{#295605}

[James Cook, 2014-09-17 22:15:28]

jamescook@chromium.org changed reviewers:
+ yoz@chromium.org

[James Cook, 2014-09-17 22:15:28]

yoz, PTAL

[Yoyo Zhou, 2014-09-18 21:08:26]

LGTM

https://codereview.chromium.org/562273006/diff/40001/chrome/common/extensions...
File chrome/common/extensions/extension_file_util_unittest.cc (right):

https://codereview.chromium.org/562273006/diff/40001/chrome/common/extensions...
chrome/common/extensions/extension_file_util_unittest.cc:56:
EXPECT_TRUE(extension2.get() == NULL);
nit: this is just EXPECT_FALSE(extension2.get())

https://codereview.chromium.org/562273006/diff/40001/chrome/common/extensions...
chrome/common/extensions/extension_file_util_unittest.cc:68:
EXPECT_TRUE(extension3.get() == NULL);
ditto

[James Cook, 2014-09-18 22:02:18]

https://codereview.chromium.org/562273006/diff/40001/chrome/common/extensions...
File chrome/common/extensions/extension_file_util_unittest.cc (right):

https://codereview.chromium.org/562273006/diff/40001/chrome/common/extensions...
chrome/common/extensions/extension_file_util_unittest.cc:56:
EXPECT_TRUE(extension2.get() == NULL);
On 2014/09/18 21:08:26, Yoyo Zhou wrote:
> nit: this is just EXPECT_FALSE(extension2.get())

Done.

https://codereview.chromium.org/562273006/diff/40001/chrome/common/extensions...
chrome/common/extensions/extension_file_util_unittest.cc:68:
EXPECT_TRUE(extension3.get() == NULL);
On 2014/09/18 21:08:26, Yoyo Zhou wrote:
> ditto

Done.

[James Cook, 2014-09-18 22:04:46]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-09-18 22:06:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/562273006/100001

[commit-bot: I haz the power, 2014-09-18 23:44:06]

Committed patchset #6 (id:100001) as 08dd8a70825a9f37238ca57f4fd30aaac1812516

[commit-bot: I haz the power, 2014-09-18 23:44:39]

Patchset 6 (id:??) landed as
https://crrev.com/f765cb48310ab9d5dcaba7ec118115a32dd7c964
Cr-Commit-Position: refs/heads/master@{#295605}

[tfarina, 2014-09-19 17:00:29]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2014-09-19 17:00:30]

Looks like you ended up doing something different than what I was thinking in
doing.

https://codereview.chromium.org/562273006/diff/100001/extensions/common/exten...
File extensions/common/extension_l10n_util_unittest.cc (right):

https://codereview.chromium.org/562273006/diff/100001/extensions/common/exten...
extensions/common/extension_l10n_util_unittest.cc:112:
install_dir.AppendASCII("extension_with_locales").Append(kLocaleFolder);
Ah, you simplified it. Cool.

Thanks!

[James Cook, 2014-09-19 17:34:44]

On 2014/09/19 17:00:30, tfarina wrote:
> Looks like you ended up doing something different than what I was thinking in
> doing.
> 
>
https://codereview.chromium.org/562273006/diff/100001/extensions/common/exten...
> File extensions/common/extension_l10n_util_unittest.cc (right):
> 
>
https://codereview.chromium.org/562273006/diff/100001/extensions/common/exten...
> extensions/common/extension_l10n_util_unittest.cc:112:
> install_dir.AppendASCII("extension_with_locales").Append(kLocaleFolder);
> Ah, you simplified it. Cool.
> 
> Thanks!

Yeah. The earlier patch was actually the more difficult one -- the hardest part
was figuring out all the _manifest_features.json entries that were missing. 
Just moving the data wasn't enough.

Thanks again for your work on extensions_unittests.  We've moved about 10% of
Chrome's unit tests to the suite (it's at ~600 tests, Chrome's unit_tests is
~6000).