Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: extensions/BUILD.gn

Issue 562273006: Move the last extensions/common unit tests to extensions_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manifest2
Patch Set: (file-tests) review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/BUILD.gn
diff --git a/extensions/BUILD.gn b/extensions/BUILD.gn
index 0b4603729fde12ecee0055c6fed02586c43c7799..007328d589f05fcbb7be2a2d698d9fbc45b50fc4 100644
--- a/extensions/BUILD.gn
+++ b/extensions/BUILD.gn
@@ -87,8 +87,6 @@ source_set("test_support") {
"test/test_extensions_client.h",
"test/test_permission_message_provider.cc",
"test/test_permission_message_provider.h",
- "test/test_permissions_provider.cc",
- "test/test_permissions_provider.h",
]
deps = [
@@ -156,10 +154,6 @@ repack("shell_and_test_pak") {
# does not have a reference to CreateNativeWebModalManager but it still links.
# The GN build fails with this symbol being undefined.
if (false) {
-# TODO(tfarina): Many extension unit tests run as part of Chrome"s
-# unit_tests target. They should be moved here, which may require some
-# refactoring (ExtensionsBrowserClient, TestingProfile, etc.).
-# http://crbug.com/348066
test("unittests") {
output_name = "extensions_unittests"
@@ -205,8 +199,10 @@ test("unittests") {
"common/api/sockets/sockets_manifest_permission_unittest.cc",
"common/csp_validator_unittest.cc",
"common/event_filter_unittest.cc",
+ "common/extension_l10n_util_unittest.cc",
"common/extension_resource_unittest.cc",
"common/extension_set_unittest.cc",
+ "common/file_util_unittest.cc",
"common/manifest_handler_unittest.cc",
"common/manifest_handlers/shared_module_manifest_unittest.cc",
"common/message_bundle_unittest.cc",

Powered by Google App Engine
This is Rietveld 408576698