Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 562273006: Move the last extensions/common unit tests to extensions_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manifest2
Patch Set: (file-tests) review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension_file_util_unittest.cc » ('j') | extensions/common/extension_l10n_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index f05c4b3050d7c576d609adf58b54390f5e707b2b..2b762650edb617e7c9c722505892d369987e53b5 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -11,12 +11,6 @@
'../components/autofill/content/renderer/test_password_autofill_agent.h',
'../components/autofill/content/renderer/test_password_generation_agent.cc',
'../components/autofill/content/renderer/test_password_generation_agent.h',
- # TODO(tfarina): Move these entries over to extensions_unittests target.
- # http://crbug.com/348066. They are duplicated here because we haven't
- # extensions_unittests running in the bots yet. Until that happens,
- # they should be kept here.
- '../extensions/common/extension_l10n_util_unittest.cc',
- '../extensions/common/file_util_unittest.cc',
# histograms.xml is analyzed by AboutFlagsHistogramTest, so this
# dependency is needed to make commit bots run unit_tests on
# histograms.xml changes.
« no previous file with comments | « no previous file | chrome/common/extensions/extension_file_util_unittest.cc » ('j') | extensions/common/extension_l10n_util_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698