extensions/extensions.gyp - Issue 562273006: Move the last extensions/common unit tests to extensions_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 562273006: Move the last extensions/common unit tests to extensions_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manifest2

Patch Set: (file-tests) review comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/extension_l10n_util_unittest.cc ('K') | « extensions/common/file_util_unittest.cc ('k') | extensions/test/data/extension_with_locales/_locales/en/messages.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index c6fd47a2f7aa5191e5a43330e0c624a66dda519c..e5303964a75ab6cd0c46633a6c1b25e152dbfe4c 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -947,8 +947,6 @@

'test/test_extensions_client.h',

'test/test_permission_message_provider.cc',

'test/test_permission_message_provider.h',

- 'test/test_permissions_provider.cc',

- 'test/test_permissions_provider.h',

# Disable c4267 warnings until we fix size_t to int truncations.

'msvs_disabled_warnings': [ 4267, ],

@@ -1004,10 +1002,6 @@

{

- # TODO(tfarina): Many extension unit tests run as part of Chrome's

- # unit_tests target. They should be moved here, which may require some

- # refactoring (ExtensionsBrowserClient, TestingProfile, etc.).

- # http://crbug.com/348066

'target_name': 'extensions_unittests',

'type': 'executable',

'dependencies': [

@@ -1089,11 +1083,13 @@

'common/api/sockets/sockets_manifest_permission_unittest.cc',

'common/csp_validator_unittest.cc',

'common/event_filter_unittest.cc',

+ 'common/extension_l10n_util_unittest.cc',

'common/extension_resource_unittest.cc',

'common/extension_set_unittest.cc',

'common/features/base_feature_provider_unittest.cc',

'common/features/complex_feature_unittest.cc',

'common/features/simple_feature_unittest.cc',

+ 'common/file_util_unittest.cc',

'common/manifest_handler_unittest.cc',

'common/manifest_handlers/externally_connectable_unittest.cc',

'common/manifest_handlers/file_handler_manifest_unittest.cc',