Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 559023002: [Android] memory_inspector: bug / UI fixes. (Closed)

Created:
6 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
johnme
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@mi1_heapdump_sigstop
Project:
chromium
Visibility:
Public.

Description

[Android] memory_inspector: bug / UI fixes. This is a set of bug / UI fixes for memory inspector, in preparetion for next CLs which will introduce integration with libheap_profiler. Changes in this CL: - Introduce mmap de-offset heplers (will be used soon for intersecting native heap traces). - Fix symbol lookup for shared_library Chrome builds. - Add RSS column to mmaps table. - Add server crash / unreachable detection. - Update prebuilts (add also desktop ones for paul.whitton@) - Make it possible to filter tests ran by run_tests. - Minor cosmetic bugfixes. BUG=340294 Committed: https://crrev.com/cd68dea40b1d339929d99f18d328a2df724a8f77 Cr-Commit-Position: refs/heads/master@{#294193}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -75 lines) Patch
M tools/memory_inspector/memory_inspector/backends/android/android_backend.py View 10 chunks +34 lines, -28 lines 0 comments Download
M tools/memory_inspector/memory_inspector/backends/android/dumpheap_native_parser.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py View 2 chunks +4 lines, -3 lines 1 comment Download
M tools/memory_inspector/memory_inspector/constants.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/memory_inspector/memory_inspector/core/memory_map.py View 3 chunks +20 lines, -2 lines 0 comments Download
M tools/memory_inspector/memory_inspector/core/memory_map_unittest.py View 1 chunk +12 lines, -4 lines 0 comments Download
M tools/memory_inspector/memory_inspector/core/native_heap.py View 3 chunks +5 lines, -2 lines 0 comments Download
M tools/memory_inspector/memory_inspector/core/stacktrace.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/background_tasks.py View 1 chunk +9 lines, -10 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/css/rootUi.css View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/js/devices.js View 1 chunk +1 line, -0 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/js/mmap.js View 1 chunk +12 lines, -7 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/js/processes.js View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/js/rootUi.js View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/js/webservice.js View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_server.py View 5 chunks +11 lines, -8 lines 0 comments Download
M tools/memory_inspector/prebuilts/memdump-android-arm.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_inspector/prebuilts/memdump-linux-x86_64.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_inspector/prebuilts/ps_ext-android-arm.sha1 View 1 chunk +1 line, -1 line 0 comments Download
A tools/memory_inspector/prebuilts/ps_ext-linux-x86_64.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/memory_inspector/run_tests View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Primiano Tucci (use gerrit)
Actually, do you mind if I postpone running webkitpy formatter later in the stage? I ...
6 years, 3 months ago (2014-09-10 16:30:54 UTC) #3
johnme
LGTM, all looks reasonable :)
6 years, 3 months ago (2014-09-10 17:18:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/559023002/20001
6 years, 3 months ago (2014-09-10 17:21:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 6e17e5b32eebce077b54448ce83d38fb89567ac9
6 years, 3 months ago (2014-09-10 18:20:02 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 18:24:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd68dea40b1d339929d99f18d328a2df724a8f77
Cr-Commit-Position: refs/heads/master@{#294193}

Powered by Google App Engine
This is Rietveld 408576698