tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py - Issue 559023002: [Android] memory_inspector: bug / UI fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py

Issue 559023002: [Android] memory_inspector: bug / UI fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mi1_heapdump_sigstop

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/memory_inspector/memory_inspector/backends/android/dumpheap_native_parser.py ('k') | tools/memory_inspector/memory_inspector/constants.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py

diff --git a/tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py b/tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py

index 703b508b8d79ffce3f5425494334b39b4f3c9b8d..d3fffb968e87c04731c14cefb80907d1ae82acb8 100644

--- a/tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py

+++ b/tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py

@@ -12,8 +12,8 @@ import logging

import os

import urllib

+from memory_inspector import constants

-_PREBUILTS_BUCKET = 'chromium-telemetry'

Primiano Tucci (use gerrit) 2014/09/10 16:30:54 I am moving this to constants.py as I plan to use

# Bypass the GCS download logic in unittests and use the *_ForTests mock.

in_test_harness = False

@@ -31,10 +31,11 @@ def GetIfChanged(local_file_path):

if not is_changed:

return

obj_name = _GetRemoteFileID(local_file_path)

- url = 'https://storage.googleapis.com/%s/%s' % (_PREBUILTS_BUCKET, obj_name)

+ url = constants.PREBUILTS_BASE_URL + obj_name

logging.info('Downloading %s prebuilt from %s.' % (local_file_path, url))

urllib.urlretrieve(url, local_file_path)

- assert(not _IsChanged(local_file_path)), 'GCS download failed.'

+ assert(not _IsChanged(local_file_path)), ('GCS download for %s failed.' %

+ local_file_path)

def _IsChanged(local_file_path):