tools/memory_inspector/memory_inspector/frontends/background_tasks.py - Issue 559023002: [Android] memory_inspector: bug / UI fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/frontends/background_tasks.py

Issue 559023002: [Android] memory_inspector: bug / UI fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mi1_heapdump_sigstop

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py ('K') | « tools/memory_inspector/memory_inspector/core/stacktrace.py ('k') | tools/memory_inspector/memory_inspector/frontends/www_content/css/rootUi.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/memory_inspector/memory_inspector/frontends/background_tasks.py

diff --git a/tools/memory_inspector/memory_inspector/frontends/background_tasks.py b/tools/memory_inspector/memory_inspector/frontends/background_tasks.py

index 1d6d6021872d12b4ce1c030f21173aa190c960b3..27d08be36b84ea4e5ad015dbaa7f2a083a8c0558 100644

--- a/tools/memory_inspector/memory_inspector/frontends/background_tasks.py

+++ b/tools/memory_inspector/memory_inspector/frontends/background_tasks.py

@@ -102,16 +102,15 @@ def TracerMain_(log, storage_path, backend_name, device_id, pid, interval,

if i < count:

time.sleep(interval)

- log.put((90, 'Symbolizing'))

- symbols = backend.ExtractSymbols(heaps_to_symbolize,

- device.settings['native_symbol_paths'] or '')

- expected_symbols_count = len(set.union(

- *[set(x.stack_frames.iterkeys()) for x in heaps_to_symbolize]))

- log.put((99, 'Symbolization complete. Got %d symbols (%.1f%%).' % (

- len(symbols), 100.0 * len(symbols) / expected_symbols_count)))

- archive.StoreSymbols(symbols)

+ if heaps_to_symbolize:

+ log.put((90, 'Symbolizing'))

+ symbols = backend.ExtractSymbols(

+ heaps_to_symbolize, device.settings['native_symbol_paths'] or '')

+ expected_symbols_count = len(set.union(

+ *[set(x.stack_frames.iterkeys()) for x in heaps_to_symbolize]))

+ log.put((99, 'Symbolization complete. Got %d symbols (%.1f%%).' % (

+ len(symbols), 100.0 * len(symbols) / expected_symbols_count)))

+ archive.StoreSymbols(symbols)

log.put((100, 'Trace complete.'))

return 0