tools/memory_inspector/memory_inspector/core/stacktrace.py - Issue 559023002: [Android] memory_inspector: bug / UI fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/core/stacktrace.py

Issue 559023002: [Android] memory_inspector: bug / UI fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mi1_heapdump_sigstop

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/memory_inspector/memory_inspector/backends/prebuilts_fetcher.py ('K') | « tools/memory_inspector/memory_inspector/core/native_heap.py ('k') | tools/memory_inspector/memory_inspector/frontends/background_tasks.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/memory_inspector/memory_inspector/core/stacktrace.py

diff --git a/tools/memory_inspector/memory_inspector/core/stacktrace.py b/tools/memory_inspector/memory_inspector/core/stacktrace.py

index 6b865b451f378f16c93965913f88b2220821fd2a..050c97628a878a5c2f7fc1621ab2b9382cacc28e 100644

--- a/tools/memory_inspector/memory_inspector/core/stacktrace.py

+++ b/tools/memory_inspector/memory_inspector/core/stacktrace.py

@@ -2,7 +2,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-import os

+import posixpath

from memory_inspector.core import symbol

@@ -67,7 +67,9 @@ class Frame(object):

@property

def exec_file_name(self):

"""Returns the file name (stripped of the path) of the executable."""

- return os.path.basename(self.exec_file_rel_path)

+ if self.exec_file_rel_path is None:

+ return None

+ return posixpath.basename(self.exec_file_rel_path.replace('\\', '/'))

@property

def raw_address(self):