Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2626)

Unified Diff: chrome/browser/sessions/base_session_service.h

Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the WeakPtr comments in files Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/instant_service.h ('k') | chrome/browser/sessions/base_session_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/base_session_service.h
diff --git a/chrome/browser/sessions/base_session_service.h b/chrome/browser/sessions/base_session_service.h
index 98f237955ac9376265e204a66c56a38518b2fdb6..527ca404a6d0c19c5cf4ca873d86d1da400d767a 100644
--- a/chrome/browser/sessions/base_session_service.h
+++ b/chrome/browser/sessions/base_session_service.h
@@ -171,9 +171,6 @@ class BaseSessionService {
// The backend.
scoped_refptr<SessionBackend> backend_;
- // Used to invoke Save.
- base::WeakPtrFactory<BaseSessionService> weak_factory_;
-
// Commands we need to send over to the backend.
std::vector<SessionCommand*> pending_commands_;
@@ -187,6 +184,9 @@ class BaseSessionService {
// A token to make sure that all tasks will be serialized.
base::SequencedWorkerPool::SequenceToken sequence_token_;
+ // Used to invoke Save.
+ base::WeakPtrFactory<BaseSessionService> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(BaseSessionService);
};
« no previous file with comments | « chrome/browser/search/instant_service.h ('k') | chrome/browser/sessions/base_session_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698