Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: chrome/browser/search/instant_service.h

Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the WeakPtr comments in files Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sessions/base_session_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/instant_service.h
diff --git a/chrome/browser/search/instant_service.h b/chrome/browser/search/instant_service.h
index b4d97c9590ada881e7a23062fee1d6a4ff652fb1..c93a177fdd2c35a6f8e01f9323bdaf1d58be4003 100644
--- a/chrome/browser/search/instant_service.h
+++ b/chrome/browser/search/instant_service.h
@@ -162,14 +162,14 @@ class InstantService : public KeyedService,
// Set to NULL if the default search provider does not support Instant.
scoped_ptr<InstantSearchPrerenderer> instant_prerenderer_;
- // Used for Top Sites async retrieval.
- base::WeakPtrFactory<InstantService> weak_ptr_factory_;
-
// Used to check whether notifications from TemplateURLService indicate a
// change that affects the default search provider.
scoped_ptr<TemplateURLData> previous_default_search_provider_;
GURL previous_google_base_url_;
+ // Used for Top Sites async retrieval.
+ base::WeakPtrFactory<InstantService> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(InstantService);
};
« no previous file with comments | « no previous file | chrome/browser/sessions/base_session_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698