Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Side by Side Diff: chrome/browser/sessions/base_session_service.h

Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the WeakPtr comments in files Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SESSIONS_BASE_SESSION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_SESSIONS_BASE_SESSION_SERVICE_H_
6 #define CHROME_BROWSER_SESSIONS_BASE_SESSION_SERVICE_H_ 6 #define CHROME_BROWSER_SESSIONS_BASE_SESSION_SERVICE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 164
165 private: 165 private:
166 friend class BetterSessionRestoreCrashTest; 166 friend class BetterSessionRestoreCrashTest;
167 167
168 // The profile. This may be null during testing. 168 // The profile. This may be null during testing.
169 Profile* profile_; 169 Profile* profile_;
170 170
171 // The backend. 171 // The backend.
172 scoped_refptr<SessionBackend> backend_; 172 scoped_refptr<SessionBackend> backend_;
173 173
174 // Used to invoke Save.
175 base::WeakPtrFactory<BaseSessionService> weak_factory_;
176
177 // Commands we need to send over to the backend. 174 // Commands we need to send over to the backend.
178 std::vector<SessionCommand*> pending_commands_; 175 std::vector<SessionCommand*> pending_commands_;
179 176
180 // Whether the backend file should be recreated the next time we send 177 // Whether the backend file should be recreated the next time we send
181 // over the commands. 178 // over the commands.
182 bool pending_reset_; 179 bool pending_reset_;
183 180
184 // The number of commands sent to the backend before doing a reset. 181 // The number of commands sent to the backend before doing a reset.
185 int commands_since_reset_; 182 int commands_since_reset_;
186 183
187 // A token to make sure that all tasks will be serialized. 184 // A token to make sure that all tasks will be serialized.
188 base::SequencedWorkerPool::SequenceToken sequence_token_; 185 base::SequencedWorkerPool::SequenceToken sequence_token_;
189 186
187 // Used to invoke Save.
188 base::WeakPtrFactory<BaseSessionService> weak_factory_;
189
190 DISALLOW_COPY_AND_ASSIGN(BaseSessionService); 190 DISALLOW_COPY_AND_ASSIGN(BaseSessionService);
191 }; 191 };
192 192
193 #endif // CHROME_BROWSER_SESSIONS_BASE_SESSION_SERVICE_H_ 193 #endif // CHROME_BROWSER_SESSIONS_BASE_SESSION_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/search/instant_service.h ('k') | chrome/browser/sessions/base_session_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698