chrome/browser/sessions/base_session_service.cc - Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/base_session_service.cc

Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed the WeakPtr comments in files Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sessions/base_session_service.h ('k') | chrome/browser/sync/sessions/notification_service_sessions_router.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/base_session_service.cc

diff --git a/chrome/browser/sessions/base_session_service.cc b/chrome/browser/sessions/base_session_service.cc

index c7e6e7a113e11e46034716340f85be04c9065a00..cad085599fdf96cf76148258444cd4644287e580 100644

--- a/chrome/browser/sessions/base_session_service.cc

+++ b/chrome/browser/sessions/base_session_service.cc

@@ -76,11 +76,11 @@ BaseSessionService::BaseSessionService(SessionType type,

Profile* profile,

const base::FilePath& path)

: profile_(profile),

- weak_factory_(this),

pending_reset_(false),

commands_since_reset_(0),

sequence_token_(

- content::BrowserThread::GetBlockingPool()->GetSequenceToken()) {

+ content::BrowserThread::GetBlockingPool()->GetSequenceToken()),

+ weak_factory_(this) {

if (profile) {

// We should never be created when incognito.

DCHECK(!profile->IsOffTheRecord());