Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 556893002: Move IdlType.may_raise_exception_on_conversion to v8_types.py (Closed)

Created:
6 years, 3 months ago by Jens Widell
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move IdlType.may_raise_exception_on_conversion to v8_types.py Also rename it v8_conversion_needs_exception_state, which is exactly what it means. The old name is somewhat misleading, since other conversions can typically also raise exceptions in practice; the difference is whether the conversion function does so via (and thus expects) an ExceptionState argument. Defining it in v8_types.py makes sense since this is a property of the V8 bindings layer's conversion API for the type, not of the type itself. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M Source/bindings/scripts/idl_types.py View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_interface.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_types.py View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jens Widell
PTAL
6 years, 3 months ago (2014-09-09 13:44:04 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-09 14:16:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/556893002/1
6 years, 3 months ago (2014-09-09 14:28:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26242)
6 years, 3 months ago (2014-09-09 16:25:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/556893002/1
6 years, 3 months ago (2014-09-09 19:20:45 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 20:08:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181669

Powered by Google App Engine
This is Rietveld 408576698