Source/bindings/scripts/v8_attributes.py - Issue 556893002: Move IdlType.may_raise_exception_on_conversion to v8_types.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 556893002: Move IdlType.may_raise_exception_on_conversion to v8_types.py (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 308e940becebdd55f1378cdb7cdc0839cad1dae3..29ec59d6c4e3b91b6f7dc6e833877f3309870e16 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -329,7 +329,7 @@ def setter_context(interface, attribute, context):

'has_setter_exception_state':

is_setter_raises_exception or has_type_checking_interface or

context['has_type_checking_unrestricted'] or

- idl_type.may_raise_exception_on_conversion,

+ idl_type.v8_conversion_needs_exception_state,

'has_type_checking_interface': has_type_checking_interface,

'is_setter_call_with_execution_context': v8_utilities.has_extended_attribute_value(

attribute, 'SetterCallWith', 'ExecutionContext'),

« no previous file with comments | « Source/bindings/scripts/idl_types.py ('k') | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »