Source/bindings/scripts/idl_types.py - Issue 556893002: Move IdlType.may_raise_exception_on_conversion to v8_types.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/idl_types.py

Issue 556893002: Move IdlType.may_raise_exception_on_conversion to v8_types.py (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/idl_types.py

diff --git a/Source/bindings/scripts/idl_types.py b/Source/bindings/scripts/idl_types.py

index 1b22eb6772ce83ce789a28946923bffb917392f7..d7c8b57d447b136d2bf3a64483b76f28bf65f675 100644

--- a/Source/bindings/scripts/idl_types.py

+++ b/Source/bindings/scripts/idl_types.py

@@ -197,11 +197,6 @@ class IdlType(IdlTypeBase):

return self.name in STRING_TYPES

@property

- def may_raise_exception_on_conversion(self):

- return (self.is_integer_type or

- self.name in ('ByteString', 'ScalarValueString'))

- @property

def is_union_type(self):

return isinstance(self, IdlUnionType)

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »