Source/bindings/scripts/v8_methods.py - Issue 556893002: Move IdlType.may_raise_exception_on_conversion to v8_types.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 556893002: Move IdlType.may_raise_exception_on_conversion to v8_types.py (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 652ea4b3adb6581bc7c4ba0f049ef35245c3f526..4fb2ec0d329300607a41a03c7e88541494b71d0f 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -164,7 +164,7 @@ def method_context(interface, method):

is_check_security_for_window or

any(argument for argument in arguments

if argument.idl_type.name == 'SerializedScriptValue' or

- argument.idl_type.may_raise_exception_on_conversion),

+ argument.idl_type.v8_conversion_needs_exception_state),

'idl_type': idl_type.base_type,

'is_call_with_execution_context': has_extended_attribute_value(method, 'CallWith', 'ExecutionContext'),

'is_call_with_script_arguments': is_call_with_script_arguments,

« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »