Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 554583003: Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed)

Created:
6 years, 3 months ago by wuhu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not have been created at this point. BUG=413481 Committed: https://crrev.com/9bb65868ce3ac1e5aae3a844beacf62281c332b6 Cr-Commit-Position: refs/heads/master@{#294703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -47 lines) Patch
M tools/perf/benchmarks/dromaeo.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/octane.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/image_decoding.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/media.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/memory.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/page_cycler.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/page_cycler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/measurements/tab_switching.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/webrtc.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/metrics/power.py View 4 chunks +14 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
wuhu
Please review when you have time
6 years, 3 months ago (2014-09-12 20:54:09 UTC) #2
nednguyen
On 2014/09/12 20:54:09, wuhu wrote: > Please review when you have time LGTM
6 years, 3 months ago (2014-09-12 21:04:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554583003/1
6 years, 3 months ago (2014-09-12 21:12:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554583003/1
6 years, 3 months ago (2014-09-12 23:22:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 20f6dc3389463e542dac2295348d41160b99daca
6 years, 3 months ago (2014-09-13 00:36:01 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9bb65868ce3ac1e5aae3a844beacf62281c332b6 Cr-Commit-Position: refs/heads/master@{#294703}
6 years, 3 months ago (2014-09-13 00:47:42 UTC) #10
dsinclair
6 years, 3 months ago (2014-09-15 13:52:27 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/562243004/ by dsinclair@chromium.org.

The reason for reverting is: It looks like the moto E perf bots are broken. This
change looks like it makes sense so I'm reverting.

crbug.com/414267.

Powered by Google App Engine
This is Rietveld 408576698