tools/perf/measurements/page_cycler.py - Issue 554583003: Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 554583003: Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/page_cycler.py

diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py

index 84c9dc25aa6f744de1491e3f1a6cfb46ad826628..08673e85134831fb42a5e74b4ed61d8451fb81dc 100644

--- a/tools/perf/measurements/page_cycler.py

+++ b/tools/perf/measurements/page_cycler.py

@@ -83,9 +83,9 @@ class PageCycler(page_test.PageTest):

else:

cls._cold_run_start_index = args.pageset_repeat * args.page_repeat

- def WillStartBrowser(self, browser):

+ def WillStartBrowser(self, platform):

"""Initialize metrics once right before the browser has been launched."""

- self._power_metric = power.PowerMetric(browser)

+ self._power_metric = power.PowerMetric(platform)

def DidStartBrowser(self, browser):

"""Initialize metrics once right after the browser has been launched."""

« no previous file with comments | « tools/perf/measurements/memory.py ('k') | tools/perf/measurements/page_cycler_unittest.py » ('j') | no next file with comments »