tools/perf/measurements/page_cycler_unittest.py - Issue 554583003: Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/page_cycler_unittest.py

Issue 554583003: Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/page_cycler_unittest.py

diff --git a/tools/perf/measurements/page_cycler_unittest.py b/tools/perf/measurements/page_cycler_unittest.py

index 90f05087372ff26368432bad1ef6dced7fca27ad..4b1e721769ac530b1e20d0f38496870b32fe9e60 100644

--- a/tools/perf/measurements/page_cycler_unittest.py

+++ b/tools/perf/measurements/page_cycler_unittest.py

@@ -109,7 +109,7 @@ class PageCyclerUnitTest(unittest.TestCase):

try:

page_cycler.memory = mock_memory_module

browser = FakeBrowser()

- cycler.WillStartBrowser(browser)

+ cycler.WillStartBrowser(options.browser_options.platform)

cycler.DidStartBrowser(browser)

finally:

page_cycler.memory = real_memory_module

« no previous file with comments | « tools/perf/measurements/page_cycler.py ('k') | tools/perf/measurements/smoothness.py » ('j') | no next file with comments »