tools/perf/measurements/smoothness.py - Issue 554583003: Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness.py

Issue 554583003: Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/smoothness.py

diff --git a/tools/perf/measurements/smoothness.py b/tools/perf/measurements/smoothness.py

index 913ad133606e7ea32c16cacfeb1f72a8c3b73007..406b32120225dcd85d39e55ff6d6e3778fbae755 100644

--- a/tools/perf/measurements/smoothness.py

+++ b/tools/perf/measurements/smoothness.py

@@ -20,8 +20,8 @@ class Smoothness(page_test.PageTest):

options.AppendExtraBrowserArgs('--running-performance-benchmark')

power.PowerMetric.CustomizeBrowserOptions(options)

- def WillStartBrowser(self, browser):

- self._power_metric = power.PowerMetric(browser)

+ def WillStartBrowser(self, platform):

+ self._power_metric = power.PowerMetric(platform)

def WillNavigateToPage(self, page, tab):

self._power_metric.Start(page, tab)

« no previous file with comments | « tools/perf/measurements/page_cycler_unittest.py ('k') | tools/perf/measurements/smoothness_unittest.py » ('j') | no next file with comments »