Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 554393009: Make chrome GN build work in component mode. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make chrome GN build work in component mode. This also fixes a resources regression (added extensions resources) that caused chrome not to run. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8f132304db80d9de8d0df51a568dda65ddec93ef

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : undo gyp changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -170 lines) Patch
M chrome/BUILD.gn View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/BUILD.gn View 1 2 chunks +34 lines, -8 lines 0 comments Download
M content/app/BUILD.gn View 2 chunks +22 lines, -36 lines 0 comments Download
M content/browser/BUILD.gn View 2 chunks +4 lines, -9 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M content/plugin/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M content/ppapi_plugin/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/app/BUILD.gn View 2 chunks +104 lines, -79 lines 0 comments Download
M content/public/browser/BUILD.gn View 4 chunks +6 lines, -2 lines 0 comments Download
M content/public/child/BUILD.gn View 2 chunks +14 lines, -2 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +13 lines, -1 line 0 comments Download
M content/public/plugin/BUILD.gn View 2 chunks +14 lines, -2 lines 0 comments Download
M content/public/renderer/BUILD.gn View 3 chunks +16 lines, -3 lines 0 comments Download
M content/public/utility/BUILD.gn View 3 chunks +16 lines, -3 lines 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M content/utility/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
brettw
6 years, 3 months ago (2014-09-10 23:40:39 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-09-10 23:46:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554393009/20001
6 years, 3 months ago (2014-09-10 23:50:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/65330) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/59315) chromium_presubmit ...
6 years, 3 months ago (2014-09-11 00:05:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554393009/40001
6 years, 3 months ago (2014-09-11 16:36:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10340)
6 years, 3 months ago (2014-09-11 16:45:29 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/8f132304db80d9de8d0df51a568dda65ddec93ef Cr-Commit-Position: refs/heads/master@{#294406}
6 years, 3 months ago (2014-09-11 17:15:01 UTC) #12
brettw
6 years, 3 months ago (2014-09-11 17:15:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 8f13230.

Powered by Google App Engine
This is Rietveld 408576698