Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1822)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/plugin/BUILD.gn

Issue 554393009: Make chrome GN build work in component mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: undo gyp changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/gpu/BUILD.gn ('k') | content/ppapi_plugin/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/plugin/BUILD.gn
diff --git a/content/plugin/BUILD.gn b/content/plugin/BUILD.gn
index 90d266efad9191250541bd89db919fbd09f1bba8..03171deaa9094d5d8a176a6381687ad04664d759 100644
--- a/content/plugin/BUILD.gn
+++ b/content/plugin/BUILD.gn
@@ -7,7 +7,10 @@ import("//build/config/features.gni")
# This is the NPAPI plugin process. It isn't used on Linux.
if (enable_plugins && !is_linux) {
source_set("plugin") {
- visibility = [ "//content/*" ]
+ # Only the public target should depend on this. All other targets (even
+ # internal content ones) should depend on the public one.
+ visibility = [ "//content/public/plugin:plugin_sources" ]
+
sources = [
"plugin_channel.cc",
"plugin_channel.h",
« no previous file with comments | « content/gpu/BUILD.gn ('k') | content/ppapi_plugin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698