Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: content/public/browser/BUILD.gn

Issue 554393009: Make chrome GN build work in component mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: undo gyp changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/app/BUILD.gn ('k') | content/public/child/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/BUILD.gn
diff --git a/content/public/browser/BUILD.gn b/content/public/browser/BUILD.gn
index c51628fbf852baa5ea767ffac549db9478a69859..60330986506a8ff2e3a9a4b35e9d902823a3efb4 100644
--- a/content/public/browser/BUILD.gn
+++ b/content/public/browser/BUILD.gn
@@ -5,6 +5,7 @@
import("//content/browser/browser.gni")
import("//build/config/ui.gni")
+# See //content/BUILD.gn for how this works.
group("browser") {
if (is_component_build) {
deps = [ "//content" ]
@@ -15,6 +16,8 @@ group("browser") {
}
source_set("browser_sources") {
+ visibility = [ "//content/*" ]
+
if (is_ios) {
# iOS doesn't get the normal file list and only takes these whitelisted
# files.
@@ -40,7 +43,7 @@ source_set("browser_sources") {
deps = [
"//content/browser",
- "//content/public/common",
+ "//content/public/common:common_sources",
"//net",
"//skia",
"//ui/accessibility",
@@ -51,7 +54,8 @@ source_set("browser_sources") {
allow_circular_includes_from = [
# This target is a pair with content/browser. They always go together and
# include headers from each other.
- "//content/browser",
+ # TODO(brettw) enable this when this permits non-dependent targets.
+ #"//content/browser",
]
# We expose skia headers in the public API.
« no previous file with comments | « content/public/app/BUILD.gn ('k') | content/public/child/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698