Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: content/renderer/BUILD.gn

Issue 554393009: Make chrome GN build work in component mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: undo gyp changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/utility/BUILD.gn ('k') | content/shell/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/BUILD.gn
diff --git a/content/renderer/BUILD.gn b/content/renderer/BUILD.gn
index 57dd73c768ea2734c7ca5f22ff7e95bafa03972d..385e2619b2e9d364f7cbca63a3f896bac051fa10 100644
--- a/content/renderer/BUILD.gn
+++ b/content/renderer/BUILD.gn
@@ -7,8 +7,9 @@ import("//build/config/ui.gni")
import("//content/renderer/renderer.gni")
source_set("renderer") {
- # Only targets in the content tree can depend directly on this target.
- visibility = [ "//content/*" ]
+ # Only the public target should depend on this. All other targets (even
+ # internal content ones) should depend on the public one.
+ visibility = [ "//content/public/renderer:renderer_sources" ]
sources = rebase_path(content_renderer_gypi_values.private_renderer_sources,
".", "//content")
@@ -26,10 +27,9 @@ source_set("renderer") {
"//cc",
"//cc/blink",
"//content:resources",
- "//content/public/child",
"//content/common:mojo_bindings",
- "//content/public/child",
- "//content/public/common",
+ "//content/public/child:child_sources",
+ "//content/public/common:common_sources",
"//gin",
"//gpu",
"//jingle:jingle_glue",
« no previous file with comments | « content/public/utility/BUILD.gn ('k') | content/shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698