Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552653003: [turbofan] Fix the node matchers. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix the node matchers. E.g. make sure that Int32Matcher matches only int32 constants, and Float64Matcher matches only float64 constants. Also remove the confusing CommonOperatorTraits, which are too easy to use in a wrong way. TEST=compiler-unittests,cctest R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23768

Patch Set 1 #

Patch Set 2 : Fixes #

Total comments: 2

Patch Set 3 : Fix arm64 #

Patch Set 4 : Address nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -311 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 3 chunks +28 lines, -37 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-operator.h View 1 chunk +0 lines, -128 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/node.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node-matchers.h View 5 chunks +31 lines, -31 lines 0 comments Download
M src/compiler/operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/representation-change.h View 1 2 3 4 chunks +11 lines, -11 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 5 chunks +13 lines, -9 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 3 chunks +26 lines, -30 lines 0 comments Download
M src/unique.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years, 3 months ago (2014-09-08 08:07:18 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/552653003/diff/20001/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/552653003/diff/20001/src/compiler/representation-change.h#newcode83 src/compiler/representation-change.h:83: return OpParameter<int32_t>(node) ? jsgraph()->TrueConstant() nit: Can we get ...
6 years, 3 months ago (2014-09-08 08:22:42 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/552653003/diff/20001/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/552653003/diff/20001/src/compiler/representation-change.h#newcode83 src/compiler/representation-change.h:83: return OpParameter<int32_t>(node) ? jsgraph()->TrueConstant() On 2014/09/08 08:22:42, Michael Starzinger ...
6 years, 3 months ago (2014-09-08 08:23:56 UTC) #4
Benedikt Meurer
6 years, 3 months ago (2014-09-08 09:16:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 23768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698