Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/compiler/arm/instruction-selector-arm.cc

Issue 552653003: [turbofan] Fix the node matchers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address nit. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/bits.h" 5 #include "src/base/bits.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
11 namespace compiler { 11 namespace compiler {
12 12
13 // Adds Arm-specific methods for generating InstructionOperands. 13 // Adds Arm-specific methods for generating InstructionOperands.
14 class ArmOperandGenerator FINAL : public OperandGenerator { 14 class ArmOperandGenerator FINAL : public OperandGenerator {
15 public: 15 public:
16 explicit ArmOperandGenerator(InstructionSelector* selector) 16 explicit ArmOperandGenerator(InstructionSelector* selector)
17 : OperandGenerator(selector) {} 17 : OperandGenerator(selector) {}
18 18
19 InstructionOperand* UseOperand(Node* node, InstructionCode opcode) { 19 InstructionOperand* UseOperand(Node* node, InstructionCode opcode) {
20 if (CanBeImmediate(node, opcode)) { 20 if (CanBeImmediate(node, opcode)) {
21 return UseImmediate(node); 21 return UseImmediate(node);
22 } 22 }
23 return UseRegister(node); 23 return UseRegister(node);
24 } 24 }
25 25
26 bool CanBeImmediate(Node* node, InstructionCode opcode) { 26 bool CanBeImmediate(Node* node, InstructionCode opcode) {
27 int32_t value; 27 Int32Matcher m(node);
28 switch (node->opcode()) { 28 if (!m.HasValue()) return false;
29 case IrOpcode::kInt32Constant: 29 int32_t value = m.Value();
30 case IrOpcode::kNumberConstant:
31 value = ValueOf<int32_t>(node->op());
32 break;
33 default:
34 return false;
35 }
36 switch (ArchOpcodeField::decode(opcode)) { 30 switch (ArchOpcodeField::decode(opcode)) {
37 case kArmAnd: 31 case kArmAnd:
38 case kArmMov: 32 case kArmMov:
39 case kArmMvn: 33 case kArmMvn:
40 case kArmBic: 34 case kArmBic:
41 return ImmediateFitsAddrMode1Instruction(value) || 35 return ImmediateFitsAddrMode1Instruction(value) ||
42 ImmediateFitsAddrMode1Instruction(~value); 36 ImmediateFitsAddrMode1Instruction(~value);
43 37
44 case kArmAdd: 38 case kArmAdd:
45 case kArmSub: 39 case kArmSub:
(...skipping 906 matching lines...) Expand 10 before | Expand all | Expand 10 after
952 } else { 946 } else {
953 DCHECK(cont->IsSet()); 947 DCHECK(cont->IsSet());
954 Emit(cont->Encode(kArmVcmpF64), g.DefineAsRegister(cont->result()), 948 Emit(cont->Encode(kArmVcmpF64), g.DefineAsRegister(cont->result()),
955 g.UseRegister(m.left().node()), g.UseRegister(m.right().node())); 949 g.UseRegister(m.left().node()), g.UseRegister(m.right().node()));
956 } 950 }
957 } 951 }
958 952
959 } // namespace compiler 953 } // namespace compiler
960 } // namespace internal 954 } // namespace internal
961 } // namespace v8 955 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698