Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 552013007: Remove outdated ANGLE_SH_VERSION if-def stuff. (Closed)

Created:
6 years, 3 months ago by Zhenyao Mo
Modified:
6 years, 3 months ago
Reviewers:
bajones
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove outdated ANGLE_SH_VERSION if-def stuff. I don't think we will ever roll back ANGLE to anything less than 126, so it should be safe to do s0. BUG= TEST=tree R=kbr@chromium.org NOTRY=true Committed: https://crrev.com/ec9ac20aef30ce99d24536462d87e2913856bfae Cr-Commit-Position: refs/heads/master@{#294049}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -219 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +0 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/mocks.h View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 10 chunks +22 lines, -32 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.h View 2 chunks +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.cc View 8 chunks +10 lines, -105 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_cache.h View 3 chunks +0 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_cache.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_unittest.cc View 6 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Zhenyao Mo
PTAL
6 years, 3 months ago (2014-09-09 21:42:55 UTC) #2
bajones
Great cleanup! Thanks! LGTM
6 years, 3 months ago (2014-09-09 21:46:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/552013007/20001
6 years, 3 months ago (2014-09-09 22:06:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/552013007/20001
6 years, 3 months ago (2014-09-10 00:14:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8311fc847d087a0eea6a52f9504d67498acc47cb
6 years, 3 months ago (2014-09-10 00:26:31 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec9ac20aef30ce99d24536462d87e2913856bfae
Cr-Commit-Position: refs/heads/master@{#294049}

Powered by Google App Engine
This is Rietveld 408576698