Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Issue 550373002: chromeos: Shorten some strings in the keyboard overlay. (Closed)

Created:
6 years, 3 months ago by Daniel Erat
Modified:
6 years, 3 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org, nkostylev+watch_chromium.org, kuscher1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

chromeos: Shorten some strings in the keyboard overlay. Rework strings in the keyboard overlay so they'll fit inside of the keys. Omitting some repetition, the changes are: Activate last launcher item -> Last shelf item Activate last tab -> Last tab Activate launcher item 1 -> Shelf item 1 Activate next tab -> Next tab Activate tab 1 -> Tab 1 Bookmark current page -> Add bookmark Cycle through input methods -> Next input method Find text again -> Find again Focus address bar in search mode -> Focus address bar for search Focus launcher -> Focus shelf Focus next pane -> Next pane Lock screen or power off -> Lock / power Magnifier decrease zoom -> Demagnify Magnifier increase zoom -> Magnify Maximize window -> Maximize Minimize window -> Minimize Open address in new tab -> Open in new tab Open file manager -> File manager Open Google Cloud Print -> Google Cloud Print Reload current page -> Reload Select previous input method -> Previous input method Show the Chrome menu -> Show Chrome menu Show message center -> Message center Show status menu -> Status menu Take screenshot -> Screenshot Toggle bookmark bar -> Bookmark bar Toggle caps lock -> Caps Lock Toggle Chromevox (spoken feedback) -> ChromeVox (spoken feedback) Toggle projection touch HUD -> Projection touch HUD Toggle speech input -> Speech input View keyboard overlay -> Keyboard overlay Also update more "launcher" references to instead be "shelf". BUG=248353, 412132 TBR=zelidrag@chromium.org Committed: https://crrev.com/583f99aeb0883bae698e59263efda2a279c66567 Cr-Commit-Position: refs/heads/master@{#293958}

Patch Set 1 #

Patch Set 2 : update metrics owners #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -97 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 10 chunks +58 lines, -58 lines 1 comment Download
M chrome/app/chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 2 chunks +19 lines, -19 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Daniel Erat
abodenha@ for string changes mazda@ for keyboard overlay stuff mpearson@ for tools/metrics approval Seeing these ...
6 years, 3 months ago (2014-09-08 20:35:26 UTC) #2
Mark P
actions.xml lgtm
6 years, 3 months ago (2014-09-08 21:35:10 UTC) #3
Albert Bodenhamer
It seems like a lot of this shortening of strings is unrelated to bug 248353 ...
6 years, 3 months ago (2014-09-08 22:16:04 UTC) #4
Daniel Erat
whoops, "Demagnify" was what i verified was present in dictionaries; i accidentally wrote "Unmagnify" in ...
6 years, 3 months ago (2014-09-08 22:27:08 UTC) #5
Albert Bodenhamer
Lgtm On Sep 8, 2014 3:27 PM, <derat@chromium.org> wrote: > whoops, "Demagnify" was what i ...
6 years, 3 months ago (2014-09-08 22:36:40 UTC) #6
mazda
lgtm
6 years, 3 months ago (2014-09-09 09:42:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/550373002/20001
6 years, 3 months ago (2014-09-09 14:42:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9638)
6 years, 3 months ago (2014-09-09 14:54:10 UTC) #11
Daniel Erat
tbr zel for approvals: chrome/browser/resources/chromeos/keyboard_overlay_data.js chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
6 years, 3 months ago (2014-09-09 15:02:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/550373002/20001
6 years, 3 months ago (2014-09-09 15:02:38 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ae3a702d63c59f44984fe232925cc27d80f618f4
6 years, 3 months ago (2014-09-09 17:15:34 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:00 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/583f99aeb0883bae698e59263efda2a279c66567
Cr-Commit-Position: refs/heads/master@{#293958}

Powered by Google App Engine
This is Rietveld 408576698