Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 547233003: [turbofan] Machine operators are globally shared singletons. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Machine operators are globally shared singletons. TEST=compiler-unittests,cctest R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23864

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Fixes2 #

Patch Set 4 : Fixes3 #

Patch Set 5 : Fixes4 #

Patch Set 6 : Windows cannot handle const #

Patch Set 7 : Next windows fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+766 lines, -305 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/change-lowering.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-unittest.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-unittest.cc View 1 2 3 5 chunks +12 lines, -12 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 3 1 chunk +133 lines, -139 lines 0 comments Download
A src/compiler/machine-operator.cc View 1 2 3 4 5 1 chunk +241 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator-unittest.cc View 1 2 3 4 5 6 1 chunk +286 lines, -48 lines 0 comments Download
M src/compiler/machine-type.h View 2 chunks +16 lines, -25 lines 0 comments Download
M src/compiler/operator.h View 2 chunks +6 lines, -9 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +1 line, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M src/unique.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-schedule.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-11 07:19:56 UTC) #1
Sven Panne
LGTM (mostly rubberstamped)
6 years, 3 months ago (2014-09-11 09:01:49 UTC) #2
Benedikt Meurer
6 years, 3 months ago (2014-09-11 10:38:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as 23864 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698