Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 546943003: Revert of Make ui gn check pass. Misc GN build improvements. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
jamesr, brettw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, ben+aura_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, oshima+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, sadrul, yoshiki+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Make ui gn check pass. Misc GN build improvements. (patchset #3 id:40001 of https://codereview.chromium.org/545313002/) Reason for revert: Broke http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/11835 [783/786 | 258.324] LINK ./chrome FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -m64 -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -pthread -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=none -Wl,-rpath=\$ORIGIN/ -Wl,-rpath-link= -Wl,--disable-new-dtags -o ./keyboard_unittests -Wl,--start-group @./keyboard_unittests.rsp -Wl,--end-group -ldl -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0 -ludev -lfontconfig -lX11 -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXss -lXtst -lpangocairo-1.0 -lpango-1.0 -lcairo -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lgconf-2 -lresolv -lfreetype -lasound -lXrandr -lcups -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lgcrypt -lz -lpthread -lcrypt -lm -lcap -ldbus-1 -lcrypto -lexpat ../../content/utility/utility_thread_impl.cc:38: error: undefined reference to 'content::UtilityThread::UtilityThread()' ../../content/utility/utility_thread_impl.cc:44: error: undefined reference to 'content::UtilityThread::UtilityThread()' ../../content/utility/utility_thread_impl.cc:49: error: undefined reference to 'content::UtilityThread::~UtilityThread()' clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. Original issue's description: > Make ui gn check pass. Misc GN build improvements. > > Content/public/app was messed up and didn't link everything properly, so this separates it out into browser and child like content/app is. > > R=jamesr@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/b41a8d6e789ac5df9a6d314cd0ad59f584f53dea TBR=jamesr@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3f1281e5b0f2d2f8a8d8bd17a108f6ed0c9c7d7f Cr-Commit-Position: refs/heads/master@{#293595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -160 lines) Patch
M build/config/BUILDCONFIG.gn View 5 chunks +0 lines, -8 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 2 chunks +2 lines, -15 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/public/app/BUILD.gn View 2 chunks +1 line, -44 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 5 chunks +1 line, -45 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/generated_extensions_api.gni View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 2 chunks +3 lines, -12 lines 0 comments Download
M tools/gn/input_file_manager.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/resources/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/shell_dialogs/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Make ui gn check pass. Misc GN build improvements.
6 years, 3 months ago (2014-09-06 00:04:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/546943003/1
6 years, 3 months ago (2014-09-06 00:06:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 769af44965339015d734347c8ebaeccecd2f92b6
6 years, 3 months ago (2014-09-06 00:22:41 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f1281e5b0f2d2f8a8d8bd17a108f6ed0c9c7d7f
Cr-Commit-Position: refs/heads/master@{#293595}

Powered by Google App Engine
This is Rietveld 408576698