Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: tools/gn/input_file_manager.cc

Issue 546943003: Revert of Make ui gn check pass. Misc GN build improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/tools/bindings/mojom.gni ('k') | ui/app_list/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/input_file_manager.cc
diff --git a/tools/gn/input_file_manager.cc b/tools/gn/input_file_manager.cc
index f358fdc2e68420b19f9e65b6c34ab6f38560953e..eb255080a9da68445cec8b3d03e4c612a7b6ae3a 100644
--- a/tools/gn/input_file_manager.cc
+++ b/tools/gn/input_file_manager.cc
@@ -215,20 +215,11 @@
}
}
- // The other load could have failed. In this case that error was probably
- // printed to the console, but we need to return something here, so make up a
+ // The other load could have failed. In this case that error will be printed
+ // to the console, but we need to return something here, so make up a
// dummy error.
- //
- // There is a race condition. The other load could have failed, but if the
- // other thread is delayed for some reason, this thread could end up
- // reporting the error to the scheduler first (since first error report
- // wins). The user will see this one and the "real" one will be discarded.
- if (!data->parsed_root) {
- *err = Err(origin, "File parse failed.",
- "If you see this, I'm really sorry, but a race condition has caused\n"
- "me to eat your error message. It was crunchy. If the parse error\n"
- "in your imported file isn't obvious, try re-running GN.");
- }
+ if (!data->parsed_root)
+ *err = Err(origin, "File parse failed");
return data->parsed_root.get();
}
« no previous file with comments | « mojo/public/tools/bindings/mojom.gni ('k') | ui/app_list/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698