ui/base/BUILD.gn - Issue 546943003: Revert of Make ui gn check pass. Misc GN build improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/BUILD.gn

Issue 546943003: Revert of Make ui gn check pass. Misc GN build improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/BUILD.gn

diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn

index 00994275e34f0c9a7a649d785cd8ce1fc2ad1264..94b1864a0065ed3c48c2c6a4668a97a9a9765e9a 100644

--- a/ui/base/BUILD.gn

+++ b/ui/base/BUILD.gn

@@ -308,10 +308,6 @@

]

} else {

deps += [ "//ui/base/ime" ]

- # http://crbug.com/408648 Circular includes from the ime sub-target to this

- # one.

- allow_circular_includes_from = [ "//ui/base/ime" ]

}

if (toolkit_views) {

« no previous file with comments | « ui/aura/BUILD.gn ('k') | ui/keyboard/BUILD.gn » ('j') | no next file with comments »