Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: ui/shell_dialogs/BUILD.gn

Issue 546943003: Revert of Make ui gn check pass. Misc GN build improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/resources/BUILD.gn ('k') | ui/wm/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 if (is_android) { 6 if (is_android) {
7 import("//build/config/android/config.gni") 7 import("//build/config/android/config.gni")
8 } 8 }
9 9
10 component("shell_dialogs") { 10 component("shell_dialogs") {
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 if (!is_android_webview_build) { 59 if (!is_android_webview_build) {
60 #deps += [ '../android/ui_android.gyp:ui_java' ] TODO(GYP) 60 #deps += [ '../android/ui_android.gyp:ui_java' ] TODO(GYP)
61 } 61 }
62 } 62 }
63 63
64 if (is_win) { 64 if (is_win) {
65 #deps += [ '../../win8/win8.gyp:metro_viewer' ] TODO(GYP) 65 #deps += [ '../../win8/win8.gyp:metro_viewer' ] TODO(GYP)
66 } 66 }
67 } 67 }
68 68
69 # TODO(GYP) enable shell_dialogs_unittests when media is converted.
70 if (false) {
71
69 test("shell_dialogs_unittests") { 72 test("shell_dialogs_unittests") {
70 sources = [ 73 sources = [
71 "select_file_dialog_win_unittest.cc", 74 "select_file_dialog_win_unittest.cc",
72 ] 75 ]
73 76
74 deps = [ 77 deps = [
75 ":shell_dialogs", 78 ":shell_dialogs",
76 "//base", 79 "//base",
77 "//base/test:test_support", 80 "//base/test:test_support",
78 "//base/test:run_all_unittests", 81 "//base/test:run_all_unittests",
79 "//testing/gtest", 82 "//testing/gtest",
80 ] 83 ]
81 } 84 }
85
86 } # if false
OLDNEW
« no previous file with comments | « ui/resources/BUILD.gn ('k') | ui/wm/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698