Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 546663003: Remove Clone() from CannedBrowsingData*Helper classes (Closed)

Created:
6 years, 3 months ago by vabr (Chromium)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Clone() from CannedBrowsingData*Helper classes The Clone() method was added in https://codereview.chromium.org/6670033, but is no longer called anywhere. This CL removes that dead code. BUG=384873 Committed: https://crrev.com/e15af4283ff44218f2b1a351cc07395c6807de10 Cr-Commit-Position: refs/heads/master@{#294834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -146 lines) Patch
M chrome/browser/browsing_data/browsing_data_appcache_helper.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_appcache_helper.cc View 1 chunk +1 line, -11 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_channel_id_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_channel_id_helper.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_cookie_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_cookie_helper.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper.cc View 1 chunk +1 line, -11 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.h View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper.cc View 1 chunk +1 line, -12 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_service_worker_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_service_worker_helper.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vabr (Chromium)
Hi Jochen, As the original author of Clone(), please review this CL. Thanks! Vaclav
6 years, 3 months ago (2014-09-05 15:39:37 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-08 12:15:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/546663003/1
6 years, 3 months ago (2014-09-15 15:04:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2a101c2083eaf701c1da9082ebd5645c125e02d1
6 years, 3 months ago (2014-09-15 16:19:14 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 16:21:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e15af4283ff44218f2b1a351cc07395c6807de10
Cr-Commit-Position: refs/heads/master@{#294834}

Powered by Google App Engine
This is Rietveld 408576698