chrome/browser/browsing_data/browsing_data_database_helper.h - Issue 546663003: Remove Clone() from CannedBrowsingData*Helper classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_database_helper.h

Issue 546663003: Remove Clone() from CannedBrowsingData*Helper classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_cookie_helper.cc ('k') | chrome/browser/browsing_data/browsing_data_database_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_database_helper.h

diff --git a/chrome/browser/browsing_data/browsing_data_database_helper.h b/chrome/browser/browsing_data/browsing_data_database_helper.h

index b714f01dcb9f86bdb155af85074ce59602b049c0..096d73a706979f6d95b9c32d7e9f9873df2b9290 100644

--- a/chrome/browser/browsing_data/browsing_data_database_helper.h

+++ b/chrome/browser/browsing_data/browsing_data_database_helper.h

@@ -115,11 +115,6 @@ class CannedBrowsingDataDatabaseHelper : public BrowsingDataDatabaseHelper {

explicit CannedBrowsingDataDatabaseHelper(Profile* profile);

- // Return a copy of the database helper. Only one consumer can use the

- // StartFetching method at a time, so we need to create a copy of the helper

- // everytime we instantiate a cookies tree model for it.

- CannedBrowsingDataDatabaseHelper* Clone();

// Add a database to the set of canned databases that is returned by this

// helper.

void AddDatabase(const GURL& origin,

@@ -150,8 +145,6 @@ class CannedBrowsingDataDatabaseHelper : public BrowsingDataDatabaseHelper {

std::set<PendingDatabaseInfo> pending_database_info_;

- Profile* profile_;

DISALLOW_COPY_AND_ASSIGN(CannedBrowsingDataDatabaseHelper);

};