chrome/browser/browsing_data/browsing_data_database_helper.cc - Issue 546663003: Remove Clone() from CannedBrowsingData*Helper classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_database_helper.cc

Issue 546663003: Remove Clone() from CannedBrowsingData*Helper classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_database_helper.h ('k') | chrome/browser/browsing_data/browsing_data_file_system_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_database_helper.cc

diff --git a/chrome/browser/browsing_data/browsing_data_database_helper.cc b/chrome/browser/browsing_data/browsing_data_database_helper.cc

index d20f04ebaee238e388cc7d8699ae8d5fcd4bd689..8d57f4c5038c5aa7295b416a82a2d282403a63d5 100644

--- a/chrome/browser/browsing_data/browsing_data_database_helper.cc

+++ b/chrome/browser/browsing_data/browsing_data_database_helper.cc

@@ -147,17 +147,7 @@ bool CannedBrowsingDataDatabaseHelper::PendingDatabaseInfo::operator<(

CannedBrowsingDataDatabaseHelper::CannedBrowsingDataDatabaseHelper(

Profile* profile)

- : BrowsingDataDatabaseHelper(profile),

- profile_(profile) {

-CannedBrowsingDataDatabaseHelper* CannedBrowsingDataDatabaseHelper::Clone() {

- DCHECK_CURRENTLY_ON(BrowserThread::UI);

- CannedBrowsingDataDatabaseHelper* clone =

- new CannedBrowsingDataDatabaseHelper(profile_);

- clone->pending_database_info_ = pending_database_info_;

- return clone;

+ : BrowsingDataDatabaseHelper(profile) {

}

void CannedBrowsingDataDatabaseHelper::AddDatabase(