Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_channel_id_helper.cc

Issue 546663003: Remove Clone() from CannedBrowsingData*Helper classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/browsing_data_channel_id_helper.h" 5 #include "chrome/browser/browsing_data/browsing_data_channel_id_helper.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 net::URLRequestContextGetter* request_context) { 158 net::URLRequestContextGetter* request_context) {
159 return new BrowsingDataChannelIDHelperImpl(request_context); 159 return new BrowsingDataChannelIDHelperImpl(request_context);
160 } 160 }
161 161
162 CannedBrowsingDataChannelIDHelper:: 162 CannedBrowsingDataChannelIDHelper::
163 CannedBrowsingDataChannelIDHelper() {} 163 CannedBrowsingDataChannelIDHelper() {}
164 164
165 CannedBrowsingDataChannelIDHelper:: 165 CannedBrowsingDataChannelIDHelper::
166 ~CannedBrowsingDataChannelIDHelper() {} 166 ~CannedBrowsingDataChannelIDHelper() {}
167 167
168 CannedBrowsingDataChannelIDHelper*
169 CannedBrowsingDataChannelIDHelper::Clone() {
170 DCHECK_CURRENTLY_ON(BrowserThread::UI);
171 CannedBrowsingDataChannelIDHelper* clone =
172 new CannedBrowsingDataChannelIDHelper();
173
174 clone->channel_id_map_ = channel_id_map_;
175 return clone;
176 }
177
178 void CannedBrowsingDataChannelIDHelper::AddChannelID( 168 void CannedBrowsingDataChannelIDHelper::AddChannelID(
179 const net::ChannelIDStore::ChannelID& channel_id) { 169 const net::ChannelIDStore::ChannelID& channel_id) {
180 DCHECK_CURRENTLY_ON(BrowserThread::UI); 170 DCHECK_CURRENTLY_ON(BrowserThread::UI);
181 channel_id_map_[channel_id.server_identifier()] = 171 channel_id_map_[channel_id.server_identifier()] =
182 channel_id; 172 channel_id;
183 } 173 }
184 174
185 void CannedBrowsingDataChannelIDHelper::Reset() { 175 void CannedBrowsingDataChannelIDHelper::Reset() {
186 channel_id_map_.clear(); 176 channel_id_map_.clear();
187 } 177 }
(...skipping 26 matching lines...) Expand all
214 for (ChannelIDMap::iterator i = channel_id_map_.begin(); 204 for (ChannelIDMap::iterator i = channel_id_map_.begin();
215 i != channel_id_map_.end(); ++i) 205 i != channel_id_map_.end(); ++i)
216 channel_id_list.push_back(i->second); 206 channel_id_list.push_back(i->second);
217 completion_callback_.Run(channel_id_list); 207 completion_callback_.Run(channel_id_list);
218 } 208 }
219 209
220 void CannedBrowsingDataChannelIDHelper::DeleteChannelID( 210 void CannedBrowsingDataChannelIDHelper::DeleteChannelID(
221 const std::string& server_id) { 211 const std::string& server_id) {
222 NOTREACHED(); 212 NOTREACHED();
223 } 213 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698