Make base::IsValidGUID() accept GUID strings in lowercase.

Make base::IsValidGUID() accept GUID strings in lowercase.

It's pretty common that GUID strings express hex digits in lowercase.
This CL modifies base::IsValidGUID() to also accept GUID strings in
lowercase, so that the function can be used to validate GUIDs not
generated by base::GenerateGUID().

BUG=None
TEST=base_unittests

Committed: https://crrev.com/57d121ace54a34516a4b758007632ac410dfe9bd
Cr-Commit-Position: refs/heads/master@{#293449}

[Ben Chan, 2014-09-04 22:53:25]

benchan@chromium.org changed reviewers:
+ mark@chromium.org

[Alex Vakulenko (Google), 2014-09-04 22:53:41]

On 2014/09/04 22:53:25, Ben Chan wrote:
> mailto:benchan@chromium.org changed reviewers:
> + mailto:mark@chromium.org

lgtm

[Mark Mentovai, 2014-09-04 22:59:04]

LGTM

https://codereview.chromium.org/546603002/diff/20001/base/guid_unittest.cc
File base/guid_unittest.cc (right):

https://codereview.chromium.org/546603002/diff/20001/base/guid_unittest.cc#ne...
base/guid_unittest.cc:31:
EXPECT_TRUE(base::IsValidGUID(base::StringToLowerASCII(guid)));
Do this with StringToUpperASCII too, in case GenerateGUID starts returning
lowercase versions someday.

[Ben Chan, 2014-09-04 23:05:17]

https://codereview.chromium.org/546603002/diff/20001/base/guid_unittest.cc
File base/guid_unittest.cc (right):

https://codereview.chromium.org/546603002/diff/20001/base/guid_unittest.cc#ne...
base/guid_unittest.cc:31:
EXPECT_TRUE(base::IsValidGUID(base::StringToLowerASCII(guid)));
On 2014/09/04 22:59:03, Mark Mentovai wrote:
> Do this with StringToUpperASCII too, in case GenerateGUID starts returning
> lowercase versions someday.

Done

I like the idea!  it's weird that StringToUpperASCII is outside base namespace
though

[Ben Chan, 2014-09-04 23:05:35]

The CQ bit was checked by benchan@chromium.org

[commit-bot: I haz the power, 2014-09-04 23:09:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benchan@chromium.org/546603002/40001

[commit-bot: I haz the power, 2014-09-05 04:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 04:11:23]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Chan, 2014-09-05 04:28:02]

The CQ bit was checked by benchan@chromium.org

[commit-bot: I haz the power, 2014-09-05 04:29:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benchan@chromium.org/546603002/40001

[commit-bot: I haz the power, 2014-09-05 05:09:10]

Committed patchset #3 (id:40001) as 8ed6f5f2ce8f4d0bea7b9a47d61e727aae2c9316

[commit-bot: I haz the power, 2014-09-10 03:37:09]

Patchset 3 (id:??) landed as
https://crrev.com/57d121ace54a34516a4b758007632ac410dfe9bd
Cr-Commit-Position: refs/heads/master@{#293449}