base/guid_unittest.cc - Issue 546603002: Make base::IsValidGUID() accept GUID strings in lowercase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/guid_unittest.cc

Issue 546603002: Make base::IsValidGUID() accept GUID strings in lowercase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/guid_unittest.cc

diff --git a/base/guid_unittest.cc b/base/guid_unittest.cc

index 18c04a9d3363d42f256d53a8dd9b915e22e5a5dc..e57eb7e0bb48249ecbd61cba34cd5ac550cd3a0d 100644

--- a/base/guid_unittest.cc

+++ b/base/guid_unittest.cc

@@ -6,6 +6,7 @@

#include <limits>

+#include "base/strings/string_util.h"

#include "testing/gtest/include/gtest/gtest.h"

#if defined(OS_POSIX)

@@ -27,6 +28,8 @@ TEST(GUIDTest, GUIDCorrectlyFormatted) {

for (int it = 0; it < kIterations; ++it) {

std::string guid = base::GenerateGUID();

EXPECT_TRUE(base::IsValidGUID(guid));

+ EXPECT_TRUE(base::IsValidGUID(base::StringToLowerASCII(guid)));

+ EXPECT_TRUE(base::IsValidGUID(StringToUpperASCII(guid)));

}

« no previous file with comments | « base/guid.cc ('k') | no next file » | no next file with comments »