Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: base/guid_unittest.cc

Issue 546603002: Make base::IsValidGUID() accept GUID strings in lowercase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/guid.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/guid.h" 5 #include "base/guid.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/strings/string_util.h"
9 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
10 11
11 #if defined(OS_POSIX) 12 #if defined(OS_POSIX)
12 TEST(GUIDTest, GUIDGeneratesAllZeroes) { 13 TEST(GUIDTest, GUIDGeneratesAllZeroes) {
13 uint64 bytes[] = { 0, 0 }; 14 uint64 bytes[] = { 0, 0 };
14 std::string clientid = base::RandomDataToGUIDString(bytes); 15 std::string clientid = base::RandomDataToGUIDString(bytes);
15 EXPECT_EQ("00000000-0000-0000-0000-000000000000", clientid); 16 EXPECT_EQ("00000000-0000-0000-0000-000000000000", clientid);
16 } 17 }
17 18
18 TEST(GUIDTest, GUIDGeneratesCorrectly) { 19 TEST(GUIDTest, GUIDGeneratesCorrectly) {
19 uint64 bytes[] = { 0x0123456789ABCDEFULL, 0xFEDCBA9876543210ULL }; 20 uint64 bytes[] = { 0x0123456789ABCDEFULL, 0xFEDCBA9876543210ULL };
20 std::string clientid = base::RandomDataToGUIDString(bytes); 21 std::string clientid = base::RandomDataToGUIDString(bytes);
21 EXPECT_EQ("01234567-89AB-CDEF-FEDC-BA9876543210", clientid); 22 EXPECT_EQ("01234567-89AB-CDEF-FEDC-BA9876543210", clientid);
22 } 23 }
23 #endif 24 #endif
24 25
25 TEST(GUIDTest, GUIDCorrectlyFormatted) { 26 TEST(GUIDTest, GUIDCorrectlyFormatted) {
26 const int kIterations = 10; 27 const int kIterations = 10;
27 for (int it = 0; it < kIterations; ++it) { 28 for (int it = 0; it < kIterations; ++it) {
28 std::string guid = base::GenerateGUID(); 29 std::string guid = base::GenerateGUID();
29 EXPECT_TRUE(base::IsValidGUID(guid)); 30 EXPECT_TRUE(base::IsValidGUID(guid));
31 EXPECT_TRUE(base::IsValidGUID(base::StringToLowerASCII(guid)));
32 EXPECT_TRUE(base::IsValidGUID(StringToUpperASCII(guid)));
30 } 33 }
31 } 34 }
32 35
33 TEST(GUIDTest, GUIDBasicUniqueness) { 36 TEST(GUIDTest, GUIDBasicUniqueness) {
34 const int kIterations = 10; 37 const int kIterations = 10;
35 for (int it = 0; it < kIterations; ++it) { 38 for (int it = 0; it < kIterations; ++it) {
36 std::string guid1 = base::GenerateGUID(); 39 std::string guid1 = base::GenerateGUID();
37 std::string guid2 = base::GenerateGUID(); 40 std::string guid2 = base::GenerateGUID();
38 EXPECT_EQ(36U, guid1.length()); 41 EXPECT_EQ(36U, guid1.length());
39 EXPECT_EQ(36U, guid2.length()); 42 EXPECT_EQ(36U, guid2.length());
40 EXPECT_NE(guid1, guid2); 43 EXPECT_NE(guid1, guid2);
41 } 44 }
42 } 45 }
OLDNEW
« no previous file with comments | « base/guid.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698