Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: base/guid.cc

Issue 546603002: Make base::IsValidGUID() accept GUID strings in lowercase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/guid_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/guid.h" 5 #include "base/guid.h"
6 6
7 #include "base/strings/string_util.h"
8
7 namespace base { 9 namespace base {
8 10
9 bool IsValidGUID(const std::string& guid) { 11 bool IsValidGUID(const std::string& guid) {
10 const size_t kGUIDLength = 36U; 12 const size_t kGUIDLength = 36U;
11 if (guid.length() != kGUIDLength) 13 if (guid.length() != kGUIDLength)
12 return false; 14 return false;
13 15
14 const std::string hexchars = "0123456789ABCDEF"; 16 for (size_t i = 0; i < guid.length(); ++i) {
15 for (uint32 i = 0; i < guid.length(); ++i) {
16 char current = guid[i]; 17 char current = guid[i];
17 if (i == 8 || i == 13 || i == 18 || i == 23) { 18 if (i == 8 || i == 13 || i == 18 || i == 23) {
18 if (current != '-') 19 if (current != '-')
19 return false; 20 return false;
20 } else { 21 } else {
21 if (hexchars.find(current) == std::string::npos) 22 if (!IsHexDigit(current))
22 return false; 23 return false;
23 } 24 }
24 } 25 }
25 26
26 return true; 27 return true;
27 } 28 }
28 29
29 } // namespace base 30 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | base/guid_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698