Signal exceptions if start/stop is called out-of-order or too many times.

Signal exceptions if start/stop is called out-of-order or too many times.

For AudioBufferSourceNodes and OscillatorNodes, start and stop must
signal errors when called more than once. An error must be signaled if
stop is not called after start.

The implementation of the legacy noteOn and noteOff methods is now
merged into start and stop. This is not backwards compatible since
noteOn and noteOff previously did allow multiple calls.

Tests have been added for these exceptions.

BUG=306139
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161113

[Raymond Toy (Google), 2013-10-31 20:27:08]

PTAL

[Ken Russell (switch to Gerrit), 2013-10-31 21:58:21]

https://codereview.chromium.org/54173005/diff/1/Source/modules/webaudio/Audio...
File Source/modules/webaudio/AudioBufferSourceNode.h (right):

https://codereview.chromium.org/54173005/diff/1/Source/modules/webaudio/Audio...
Source/modules/webaudio/AudioBufferSourceNode.h:99: void startPlaying(bool
isGrain, double when, double grainOffset, double grainDuration);
Could you please delete this overload and just fold its body into the version
taking ExceptionState& as the last argument?

[Raymond Toy (Google), 2013-10-31 22:12:44]

https://codereview.chromium.org/54173005/diff/1/Source/modules/webaudio/Audio...
File Source/modules/webaudio/AudioBufferSourceNode.h (right):

https://codereview.chromium.org/54173005/diff/1/Source/modules/webaudio/Audio...
Source/modules/webaudio/AudioBufferSourceNode.h:99: void startPlaying(bool
isGrain, double when, double grainOffset, double grainDuration);
On 2013/10/31 21:58:22, Ken Russell wrote:
> Could you please delete this overload and just fold its body into the version
> taking ExceptionState& as the last argument?

It's needed by noteGrainOn, which doesn't pass in an exception.  I can make
noteGrainOn raise exceptions and get rid of the extra startPlaying.

[Ken Russell (switch to Gerrit), 2013-10-31 22:14:25]

https://codereview.chromium.org/54173005/diff/1/Source/modules/webaudio/Audio...
File Source/modules/webaudio/AudioBufferSourceNode.h (right):

https://codereview.chromium.org/54173005/diff/1/Source/modules/webaudio/Audio...
Source/modules/webaudio/AudioBufferSourceNode.h:99: void startPlaying(bool
isGrain, double when, double grainOffset, double grainDuration);
On 2013/10/31 22:12:45, rtoy wrote:
> On 2013/10/31 21:58:22, Ken Russell wrote:
> > Could you please delete this overload and just fold its body into the
version
> > taking ExceptionState& as the last argument?
> 
> It's needed by noteGrainOn, which doesn't pass in an exception.  I can make
> noteGrainOn raise exceptions and get rid of the extra startPlaying.

I think that would be better.

[Raymond Toy (Google), 2013-10-31 22:30:53]

https://codereview.chromium.org/54173005/diff/1/Source/modules/webaudio/Audio...
File Source/modules/webaudio/AudioBufferSourceNode.h (right):

https://codereview.chromium.org/54173005/diff/1/Source/modules/webaudio/Audio...
Source/modules/webaudio/AudioBufferSourceNode.h:99: void startPlaying(bool
isGrain, double when, double grainOffset, double grainDuration);
On 2013/10/31 22:14:25, Ken Russell wrote:
> On 2013/10/31 22:12:45, rtoy wrote:
> > On 2013/10/31 21:58:22, Ken Russell wrote:
> > > Could you please delete this overload and just fold its body into the
> version
> > > taking ExceptionState& as the last argument?
> > 
> > It's needed by noteGrainOn, which doesn't pass in an exception.  I can make
> > noteGrainOn raise exceptions and get rid of the extra startPlaying.
> 
> I think that would be better.

Done.

[Ken Russell (switch to Gerrit), 2013-10-31 22:52:40]

That's cleaner. LGTM

[Raymond Toy (Google), 2013-10-31 23:04:49]

On 2013/10/31 22:52:40, Ken Russell wrote:
> That's cleaner. LGTM

Thanks!

[commit-bot: I haz the power, 2013-10-31 23:05:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtoy@google.com/54173005/80001

[commit-bot: I haz the power, 2013-11-01 00:14:10]

Change committed as 161113