Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2095)

Unified Diff: Source/modules/webaudio/AudioBufferSourceNode.h

Issue 54173005: Signal exceptions if start/stop is called out-of-order or too many times. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/webaudio/dom-exceptions-expected.txt ('k') | Source/modules/webaudio/AudioBufferSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioBufferSourceNode.h
diff --git a/Source/modules/webaudio/AudioBufferSourceNode.h b/Source/modules/webaudio/AudioBufferSourceNode.h
index 99e7c0778bafd620bf52520ed9c046e23eea1ced..9eafdb201b4307bfd0c3ada0c0b149f3e2f9c897 100644
--- a/Source/modules/webaudio/AudioBufferSourceNode.h
+++ b/Source/modules/webaudio/AudioBufferSourceNode.h
@@ -61,11 +61,12 @@ public:
unsigned numberOfChannels();
// Play-state
- void start(double when = 0);
- void start(double when, double grainOffset);
- void start(double when, double grainOffset, double grainDuration);
+ void start(ExceptionState&);
+ void start(double when, ExceptionState&);
+ void start(double when, double grainOffset, ExceptionState&);
+ void start(double when, double grainOffset, double grainDuration, ExceptionState&);
- void noteGrainOn(double when, double grainOffset, double grainDuration);
+ void noteGrainOn(double when, double grainOffset, double grainDuration, ExceptionState&);
// Note: the attribute was originally exposed as .looping, but to be more consistent in naming with <audio>
// and with how it's described in the specification, the proper attribute name is .loop
@@ -95,7 +96,7 @@ public:
private:
AudioBufferSourceNode(AudioContext*, float sampleRate);
- void startPlaying(bool isGrain, double when, double grainOffset, double grainDuration);
+ void startPlaying(bool isGrain, double when, double grainOffset, double grainDuration, ExceptionState&);
// Returns true on success.
bool renderFromBuffer(AudioBus*, unsigned destinationFrameOffset, size_t numberOfFrames);
« no previous file with comments | « LayoutTests/webaudio/dom-exceptions-expected.txt ('k') | Source/modules/webaudio/AudioBufferSourceNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698