Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 541233002: Mojo: Factor Channel::EndpointInfo out to ChannelEndpoint. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Factor Channel::EndpointInfo out to ChannelEndpoint. Also do a bunch of other small things. See the plan at the top of channel_endpoint.h. R=darin@chromium.org Committed: https://crrev.com/633614a67da058685dda839771a887c54f987a62 Cr-Commit-Position: refs/heads/master@{#293444}

Patch Set 1 #

Patch Set 2 : stupid msvs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -161 lines) Patch
M mojo/mojo_base.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/system/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/system/channel.h View 4 chunks +6 lines, -91 lines 0 comments Download
M mojo/system/channel.cc View 1 15 chunks +64 lines, -70 lines 0 comments Download
A mojo/system/channel_endpoint.h View 1 chunk +137 lines, -0 lines 0 comments Download
A mojo/system/channel_endpoint.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 3 months ago (2014-09-04 23:23:33 UTC) #1
darin (slow to review)
LGTM
6 years, 3 months ago (2014-09-04 23:40:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/541233002/20001
6 years, 3 months ago (2014-09-05 00:21:33 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 596337174cd651d3efe1b2353f1ecaebd76bba8e
6 years, 3 months ago (2014-09-05 05:00:20 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:00 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/633614a67da058685dda839771a887c54f987a62
Cr-Commit-Position: refs/heads/master@{#293444}

Powered by Google App Engine
This is Rietveld 408576698