Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 540903002: Flatten property_kind into state. Add UNKNOWN as a state for dict-mode receivers (Closed)

Created:
6 years, 3 months ago by Toon Verwaest
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Flatten property_kind into state. Add UNKNOWN as a state for dict-mode receivers BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23692

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add DCHECKs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -329 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +30 lines, -17 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ic.cc View 10 chunks +17 lines, -15 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/lookup.h View 1 8 chunks +4 lines, -20 lines 0 comments Download
M src/lookup.cc View 1 2 7 chunks +20 lines, -63 lines 0 comments Download
M src/lookup-inl.h View 2 chunks +25 lines, -3 lines 0 comments Download
M src/objects.cc View 22 chunks +138 lines, -150 lines 0 comments Download
M src/runtime.cc View 8 chunks +26 lines, -33 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Toon Verwaest
PTAL
6 years, 3 months ago (2014-09-04 12:13:50 UTC) #2
Yang
On 2014/09/04 12:13:50, Toon Verwaest wrote: > PTAL lgtm.
6 years, 3 months ago (2014-09-04 12:22:58 UTC) #3
Toon Verwaest
6 years, 3 months ago (2014-09-04 12:28:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 23692 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698