test/cctest/test-api.cc - Issue 540903002: Flatten property_kind into state. Add UNKNOWN as a state for dict-mode receivers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 540903002: Flatten property_kind into state. Add UNKNOWN as a state for dict-mode receivers (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add DCHECKs Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index a00eb0de5a47c908c55384af8ce25fa83c8ac13c..1a1879e8ef6f47ef689fcd68eb46e9df6879c8c4 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -2045,8 +2045,7 @@ THREADED_TEST(ExecutableAccessorIsPreservedOnAttributeChange) {

i::LookupResult lookup(i_isolate);

i::Handle<i::String> name(v8::Utils::OpenHandle(*v8_str("length")));

i::LookupIterator it(a, name, i::LookupIterator::OWN_SKIP_INTERCEPTOR);

- CHECK_NE(i::LookupIterator::ACCESS_CHECK, it.state());

- CHECK(it.HasProperty());

+ CHECK_EQ(i::LookupIterator::ACCESSOR, it.state());

CHECK(it.GetAccessors()->IsExecutableAccessorInfo());

}

« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »