Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic/arm64/handler-compiler-arm64.cc

Issue 540903002: Flatten property_kind into state. Add UNKNOWN as a state for dict-mode receivers (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add DCHECKs Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic/arm/handler-compiler-arm.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 742 matching lines...) Expand 10 before | Expand all | Expand 10 after
753 DCHECK(holder_reg.is(receiver()) || holder_reg.is(scratch1())); 753 DCHECK(holder_reg.is(receiver()) || holder_reg.is(scratch1()));
754 754
755 // Preserve the receiver register explicitly whenever it is different from the 755 // Preserve the receiver register explicitly whenever it is different from the
756 // holder and it is needed should the interceptor return without any result. 756 // holder and it is needed should the interceptor return without any result.
757 // The ACCESSOR case needs the receiver to be passed into C++ code, the FIELD 757 // The ACCESSOR case needs the receiver to be passed into C++ code, the FIELD
758 // case might cause a miss during the prototype check. 758 // case might cause a miss during the prototype check.
759 bool must_perform_prototype_check = 759 bool must_perform_prototype_check =
760 !holder().is_identical_to(it->GetHolder<JSObject>()); 760 !holder().is_identical_to(it->GetHolder<JSObject>());
761 bool must_preserve_receiver_reg = 761 bool must_preserve_receiver_reg =
762 !receiver().is(holder_reg) && 762 !receiver().is(holder_reg) &&
763 (it->property_kind() == LookupIterator::ACCESSOR || 763 (it->state() == LookupIterator::ACCESSOR || must_perform_prototype_check);
764 must_perform_prototype_check);
765 764
766 // Save necessary data before invoking an interceptor. 765 // Save necessary data before invoking an interceptor.
767 // Requires a frame to make GC aware of pushed pointers. 766 // Requires a frame to make GC aware of pushed pointers.
768 { 767 {
769 FrameScope frame_scope(masm(), StackFrame::INTERNAL); 768 FrameScope frame_scope(masm(), StackFrame::INTERNAL);
770 if (must_preserve_receiver_reg) { 769 if (must_preserve_receiver_reg) {
771 __ Push(receiver(), holder_reg, this->name()); 770 __ Push(receiver(), holder_reg, this->name());
772 } else { 771 } else {
773 __ Push(holder_reg, this->name()); 772 __ Push(holder_reg, this->name());
774 } 773 }
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 // Return the generated code. 837 // Return the generated code.
839 return GetCode(kind(), Code::FAST, name); 838 return GetCode(kind(), Code::FAST, name);
840 } 839 }
841 840
842 841
843 #undef __ 842 #undef __
844 } 843 }
845 } // namespace v8::internal 844 } // namespace v8::internal
846 845
847 #endif // V8_TARGET_ARCH_IA32 846 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm/handler-compiler-arm.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698